hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12134) Pig personality always fails at precheck_javac and check_patch_javac
Date Sun, 28 Jun 2015 23:14:04 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kengo Seki updated HADOOP-12134:
--------------------------------
    Attachment: HADOOP-12134.HADOOP-12111.01.patch

Attaching a patch. The test-patch result before applying this patch:

{code}
[sekikn@mobile hadoop]$ cat /tmp/test.patch 
diff --git test/org/apache/pig/TestMain.java test/org/apache/pig/TestMain.java
index e1c8111..67c4d8e 100644
--- test/org/apache/pig/TestMain.java
+++ test/org/apache/pig/TestMain.java
@@ -27,6 +27,7 @@ import java.io.BufferedWriter;
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
+import java.nio.charset.Charset;
 import java.util.Properties;
 
 import org.apache.commons.logging.Log;
@@ -39,7 +40,6 @@ import org.apache.pig.tools.parameters.ParameterSubstitutionException;
 import org.apache.pig.tools.pigstats.PigStats;
 import org.junit.Test;
 
-import java.nio.charset.Charset;
 import com.google.common.io.Files;
 
 public class TestMain {
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=../pig --project=pig /tmp/test.patch

(snip)

| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|  -1  |         javac  |  0m 54s    | root in trunk failed. 
|  +1  |       javadoc  |  1m 27s    | trunk passed 
|  +1  |       @author  |  0m 00s    | The patch does not contain any @author 
|      |                |            | tags.
|  -1  |    test4tests  |  0m 00s    | The patch doesn't appear to include any 
|      |                |            | new or modified tests. Please justify why
|      |                |            | no new tests are needed for this patch.
|      |                |            | Also please list what manual steps were
|      |                |            | performed to verify this patch.
|  +1  |    checkstyle  |  0m 52s    | trunk passed 
|  -1  |         javac  |  0m 57s    | root in the patch failed. 
|  +1  |       javadoc  |  1m 35s    | the patch passed 
|  +1  |    asflicense  |  0m 30s    | Patch does not generate ASF License 
|      |                |            | warnings.
|  +1  |    checkstyle  |  0m 49s    | the patch passed 
|  +1  |    whitespace  |  0m 00s    | Patch has no whitespace issues. 
|  +1  |      findbugs  |  4m 51s    | the patch passed 
|      |                |  15m 38s   | 
{code}

and after:

{code}
| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|  +1  |         javac  |  1m 00s    | trunk passed 
|  +1  |       javadoc  |  1m 29s    | trunk passed 
|  +1  |       @author  |  0m 00s    | The patch does not contain any @author 
|      |                |            | tags.
|  -1  |    test4tests  |  0m 00s    | The patch doesn't appear to include any 
|      |                |            | new or modified tests. Please justify why
|      |                |            | no new tests are needed for this patch.
|      |                |            | Also please list what manual steps were
|      |                |            | performed to verify this patch.
|  +1  |    checkstyle  |  0m 55s    | trunk passed 
|  +1  |         javac  |  0m 56s    | the patch passed 
|  +1  |       javadoc  |  1m 27s    | the patch passed 
|  +1  |    asflicense  |  0m 35s    | Patch does not generate ASF License 
|      |                |            | warnings.
|  +1  |    checkstyle  |  0m 51s    | the patch passed 
|  +1  |    whitespace  |  0m 00s    | Patch has no whitespace issues. 
|  +1  |      findbugs  |  3m 49s    | the patch passed 
|      |                |  14m 53s   | 
{code}

Java checks are improved. test4tests failure is another problem, so I'll file it later.

> Pig personality always fails at precheck_javac and check_patch_javac
> --------------------------------------------------------------------
>
>                 Key: HADOOP-12134
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12134
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Kengo Seki
>         Attachments: HADOOP-12134.HADOOP-12111.01.patch
>
>
> Currently, pig personality always fails at precheck_javac and check_patch_javac by the
following error:
> {code}
> forrest.check:
> BUILD FAILED
> /Users/sekikn/pig/build.xml:648: 'forrest.home' is not defined.       Please pass -Dforrest.home=<base
of Apache Forrest installation> to Ant on the command-line.
> {code}
> This is because "tar" target depends on "docs" via "package". But publishing documents
isn't needed in javac phase. Probably "piggybank" target is suitable for the purpose of this
phase. It kicks "jar" target also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message