hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12118) Validate xml configuration files with XML Schema
Date Fri, 26 Jun 2015 19:59:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603503#comment-14603503

Christopher Tubbs commented on HADOOP-12118:

Honestly, the manual walking of the xml file in code to validate it seems like a terrible
idea to me. It'd be so much cleaner to just provide an XSD (XML Schema Document), which can
be validated with xmllint or in code. It would also clearly document the schema expected in
the document, which can go a long way towards helping automated tools understand how to update/present
the file, even as it changes over time (if it changes, which it probably won't).

> Validate xml configuration files with XML Schema
> ------------------------------------------------
>                 Key: HADOOP-12118
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12118
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Christopher Tubbs
>         Attachments: HADOOP-7947.branch-2.1.patch
> I spent an embarrassingly long time today trying to figure out why the following wouldn't
> {code}
> <property>
>   <key>fs.defaultFS</key>
>   <value>hdfs://localhost:9000</value>
> </property>
> {code}
> I just kept getting an error about no authority for {{fs.defaultFS}}, with a value of
{{file:///}}, which made no sense... because I knew it was there.
> The problem was that the {{core-site.xml}} was parsed entirely without any validation.
This seems incorrect. The very least that could be done is a simple XML Schema validation
against an XSD, before parsing. That way, users will get immediate failures on common typos
and other problems in the xml configuration files.

This message was sent by Atlassian JIRA

View raw message