hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhihai xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12117) Potential NPE from Configuration#loadProperty with allowNullValueProperties set.
Date Wed, 24 Jun 2015 20:20:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600075#comment-14600075
] 

zhihai xu commented on HADOOP-12117:
------------------------------------

I uploaded a patch HADOOP-12117.000.patch for review, the patch will set {{value}} before
access it and also checking {{allowNullValueProperties}} is not necessary inside {{if}} statement,
because {{allowNullValueProperties}} will guarantee being true if {{value}} is null.

> Potential NPE from Configuration#loadProperty with allowNullValueProperties set.
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-12117
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12117
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.7.1
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: HADOOP-12117.000.patch
>
>
> Potential NPE from Configuration#loadProperty with allowNullValueProperties set.
> The following code will cause NPE:
> {code}
> } else if (!value.equals(properties.getProperty(attr))) {
> {code}
> Because if {{allowNullValueProperties}} is true, {{value}} is null and {{finalParameters}}
contains {{attr}}, NullPointerException will happen



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message