hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12116) Fix unrecommended syntax usages in hadoop/hdfs/yarn script for cygwin in branch-2
Date Wed, 24 Jun 2015 21:26:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600178#comment-14600178
] 

Hadoop QA commented on HADOOP-12116:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 34s | Pre-patch branch-2 compilation is healthy.
|
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   5m 48s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 42s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck |   0m  4s | There were no new shellcheck (v0.3.3) issues.
|
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 21s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | common tests |  21m 40s | Tests passed in hadoop-common. |
| {color:green}+1{color} | hdfs tests | 159m 54s | Tests passed in hadoop-hdfs. |
| | | 214m  5s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12741660/HADOOP-12116-branch-2.001.patch
|
| Optional Tests | javadoc javac unit shellcheck |
| git revision | branch-2 / 1392d1a |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7031/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7031/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7031/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7031/console |


This message was automatically generated.

> Fix unrecommended syntax usages in hadoop/hdfs/yarn script for cygwin in branch-2
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-12116
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12116
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: HADOOP-12116-branch-2.001.patch
>
>
> We're using syntax like "if $cygwin; then" which may be errorounsly evaluated into true
if cygwin is unset. We need to fix this in branch-2. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message