hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12074) in Shell.java#runCommand() while catching InterruptedException, throw new IOException(ie) instead of IOException(ie.getMessage())
Date Mon, 08 Jun 2015 12:09:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577093#comment-14577093
] 

Steve Loughran commented on HADOOP-12074:
-----------------------------------------

Good idea.
I'd recommend going one step further and throwing an {{InterruptedIOException(cause)}} so
the caller can act on it without looking inside

> in Shell.java#runCommand() while catching InterruptedException, throw new IOException(ie)
instead of IOException(ie.getMessage())
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12074
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Lavkesh Lahngir
>            Assignee: Lavkesh Lahngir
>            Priority: Trivial
>
> Instead of creating IOException with message make InterruptedException the cause of IOException,
so that whoever calling shell executor can make use of it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message