hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12045) Enable LocalFileSystem#setTimes to change atime
Date Fri, 19 Jun 2015 22:18:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594038#comment-14594038
] 

Chris Nauroth commented on HADOOP-12045:
----------------------------------------

[~fjk], thank you for the updated patch.  I have just 2 more small comments.

# Nitpick: In {{testSetTimesSymlinkToDir}}, please use {{"dir"}} instead of {{"file"}} for
the sub-directory name.
# I think we also can update {{TestCopyPreserveFlag}} as part of this patch.  Currently, it
only checks mtime, but now it can check atime too.

After addressing that, I think this will be all done.

> Enable LocalFileSystem#setTimes to change atime
> -----------------------------------------------
>
>                 Key: HADOOP-12045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12045
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Kazuho Fujii
>            Assignee: Kazuho Fujii
>            Priority: Minor
>         Attachments: HADOOP-12045.001.patch, HADOOP-12045.002.patch, HADOOP-12045.003.patch,
HADOOP-12045.004-1.patch, HADOOP-12045.004-2.patch
>
>
> LocalFileSystem#setTimes method can not change the last access time currently.
> With java.nio.file package in Java 7, we can implement the function easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message