hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "J.Andreina (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12009) FileSystemContractBaseTest:testListStatus should not assume listStatus returns sorted results
Date Thu, 04 Jun 2015 11:35:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572585#comment-14572585
] 

J.Andreina commented on HADOOP-12009:
-------------------------------------

Checkstyle errors are related to file length exceeding 2000 lines.
Please review the patch.

> FileSystemContractBaseTest:testListStatus should not assume listStatus returns sorted
results
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12009
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: J.Andreina
>            Priority: Minor
>         Attachments: HADOOP-12009.1.patch
>
>
> FileSystem.listStatus does not guarantee that implementations will return sorted entries:
> {code}  /**
>    * List the statuses of the files/directories in the given path if the path is
>    * a directory.
>    * 
>    * @param f given path
>    * @return the statuses of the files/directories in the given patch
>    * @throws FileNotFoundException when the path does not exist;
>    *         IOException see specific implementation
>    */
>   public abstract FileStatus[] listStatus(Path f) throws FileNotFoundException, 
>                                                          IOException;{code}
> However, FileSystemContractBaseTest, expects the elements to come back sorted:
> {code}    Path[] testDirs = { path("/test/hadoop/a"),
>                         path("/test/hadoop/b"),
>                         path("/test/hadoop/c/1"), };
>    
>     // ...
>     paths = fs.listStatus(path("/test/hadoop"));
>     assertEquals(3, paths.length);
>     assertEquals(path("/test/hadoop/a"), paths[0].getPath());
>     assertEquals(path("/test/hadoop/b"), paths[1].getPath());
>     assertEquals(path("/test/hadoop/c"), paths[2].getPath());{code}
> We should pass this test as long as all the paths are there, regardless of their ordering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message