hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11994) smart-apply-patch wrongly assumes that git is infallible
Date Thu, 04 Jun 2015 17:55:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573257#comment-14573257
] 

Arpit Agarwal commented on HADOOP-11994:
----------------------------------------

+1, self-test with your patch which (intentionally?) fails with git apply but succeeds with
patch. Committing shortly.

> smart-apply-patch wrongly assumes that git is infallible
> --------------------------------------------------------
>
>                 Key: HADOOP-11994
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11994
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>              Labels: build, test-patch
>         Attachments: HADOOP-11994.001.patch
>
>
> Even if git fails, smart-apply-patch should try the normal patch command.  I've seen
a few patches now where git apply fails, but patch does not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message