hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7817) RawLocalFileSystem.append() should give FSDataOutputStream with accurate .getPos()
Date Wed, 10 Jun 2015 05:26:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580042#comment-14580042
] 

Vinayakumar B commented on HADOOP-7817:
---------------------------------------

bq. We can close FileSystem by making fileSys static in a method with annotation @AfterClass
but I felt it may be un related change for this JIRA context as it's an old file and some
other test classes for example TestCryptoStreamsForLocalFS are also not closing localFS. 
So, we can file a separate JIRA to handle this in all such files. What is your opinion?
Since the whole test is moved to {{TestLocalFileSystem}}, this change is not needed for local
fs.
Anyway, my main concern was the closing of open streams, thats handled in latest patch. So
I am fine with that.

Latest patch looks good to me. +1.
Will commit soon

> RawLocalFileSystem.append() should give FSDataOutputStream with accurate .getPos()
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7817
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7817
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 1.0.0
>            Reporter: Kristofer Tomasette
>            Assignee: kanaka kumar avvaru
>            Priority: Minor
>         Attachments: HADOOP-7817-01.patch, HADOOP-7817-02.patch, HADOOP-7817.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When RawLocalFileSyste.append() is called it returns an FSDataOutputStream whose .getPos()
returns 0.
> getPos() should return position in the file where appends will start writing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message