Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Sun, 24 May 2015 04:21:18 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12831205.1432076118000.18451.1432441277992@Atlassian.JIRA>
In-Reply-To: <JIRA.12831205.1432076118000@Atlassian.JIRA>
References: <JIRA.12831205.1432076118000@Atlassian.JIRA>
 <JIRA.12831205.1432076118313@arcas>
Subject: [jira] [Commented] (HADOOP-12002) test-patch.sh needs to verify all
 of the findbugs tools exist
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557627#comment-14557627 ] 

Hadoop QA commented on HADOOP-12002:
------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as test-patch has been patched. |
| {color:green}+1{color} | release audit |   0m 14s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck |   0m  8s | There were no new shellcheck (v0.3.3) issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| | |   0m 25s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12735050/HADOOP-12002.001.patch |
| Optional Tests | shellcheck |
| git revision | trunk / 446d515 |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6808/console |


This message was automatically generated.

> test-patch.sh needs to verify all of the findbugs tools exist
> -------------------------------------------------------------
>
>                 Key: HADOOP-12002
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12002
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Sidharta Seethana
>            Assignee: Kengo Seki
>            Priority: Critical
>              Labels: test-patch
>         Attachments: HADOOP-12002.001.patch
>
>
> {{test-patch.sh}} was used with {{FINDBUGS_HOME}} set. See below for an example - there were 4 findbugs warnings generated - however, {{test-patch.sh}} doesn't seem to realize that there are missing findbugs tools and +1s the finbugs check. 
> {quote}
>  Running findbugs in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
> mvn clean test findbugs:findbugs -DskipTests -DhadoopPatchProcess > /private/tmp/hadoop-test-patch/71089/patchFindBugsOutputhadoop-yarn-server-nodemanager.txt 2>&1
> <snip>hadoop/dev-support/test-patch.sh: line 1907: /usr/local/Cellar/findbugs/3.0.0/bin/setBugDatabaseInfo: No such file or directory
> <snip>hadoop/dev-support/test-patch.sh: line 1915: /usr/local/Cellar/findbugs/3.0.0/bin/filterBugs: No such file or directory
> Found  Findbugs warnings (<snip>hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/findbugsXml.xml)
> <snip>hadoop/dev-support/test-patch.sh: line 1921: /usr/local/Cellar/findbugs/3.0.0/bin/convertXmlToText: No such file or directory
> [Mon May 18 18:08:52 PDT 2015 DEBUG]: Stop clock
> Elapsed time:   0m 38s
> {quote}
> Findbugs check reported as successful : 
> {quote}
> |  +1  |           findbugs  |  0m 38s    | The patch does not introduce any 
> |      |                     |            | new Findbugs (version 3.0.0)
> |      |                     |            | warnings.
> |      |                     |  23m 51s   | 
> {quote}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)