Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A8019107D1 for ; Tue, 19 May 2015 18:17:06 +0000 (UTC) Received: (qmail 21255 invoked by uid 500); 19 May 2015 18:17:01 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 21212 invoked by uid 500); 19 May 2015 18:17:01 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 21200 invoked by uid 99); 19 May 2015 18:17:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 18:17:01 +0000 Date: Tue, 19 May 2015 18:17:01 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11969) ThreadLocal initialization in several classes is not thread safe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550927#comment-14550927 ] Colin Patrick McCabe commented on HADOOP-11969: ----------------------------------------------- This probably needs to be rebased after HADOOP-11970 > ThreadLocal initialization in several classes is not thread safe > ---------------------------------------------------------------- > > Key: HADOOP-11969 > URL: https://issues.apache.org/jira/browse/HADOOP-11969 > Project: Hadoop Common > Issue Type: Bug > Components: io > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Critical > Labels: thread-safety > Attachments: HADOOP-11969.1.patch, HADOOP-11969.2.patch, HADOOP-11969.3.patch, HADOOP-11969.4.patch > > > Right now, the initialization of hte thread local factories for encoder / decoder in Text are not marked final. This means they end up with a static initializer that is not guaranteed to be finished running before the members are visible. > Under heavy contention, this means during initialization some users will get an NPE: > {code} > (2015-05-05 08:58:03.974 : solr_server_log.log) > org.apache.solr.common.SolrException; null:java.lang.NullPointerException > at org.apache.hadoop.io.Text.decode(Text.java:406) > at org.apache.hadoop.io.Text.decode(Text.java:389) > at org.apache.hadoop.io.Text.toString(Text.java:280) > at org.apache.hadoop.hdfs.protocolPB.PBHelper.convert(PBHelper.java:764) > at org.apache.hadoop.hdfs.protocol.datatransfer.DataTransferProtoUtil.buildBaseHeader(DataTransferProtoUtil.java:81) > at org.apache.hadoop.hdfs.protocol.datatransfer.DataTransferProtoUtil.buildClientHeader(DataTransferProtoUtil.java:71) > at org.apache.hadoop.hdfs.protocol.datatransfer.Sender.readBlock(Sender.java:101) > at org.apache.hadoop.hdfs.RemoteBlockReader2.newBlockReader(RemoteBlockReader2.java:400) > at org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReader(BlockReaderFactory.java:785) > at org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReaderFromTcp(BlockReaderFactory.java:663) > at org.apache.hadoop.hdfs.BlockReaderFactory.build(BlockReaderFactory.java:327) > at org.apache.hadoop.hdfs.DFSInputStream.actualGetFromOneDataNode(DFSInputStream.java:1027) > at org.apache.hadoop.hdfs.DFSInputStream.fetchBlockByteRange(DFSInputStream.java:974) > at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:1305) > at org.apache.hadoop.fs.FSInputStream.readFully(FSInputStream.java:78) > at org.apache.hadoop.fs.FSDataInputStream.readFully(FSDataInputStream.java:107) > ... SNIP... > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)