Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 14 May 2015 19:24:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12829855.1431611163000.117191.1431631440134@Atlassian.JIRA>
In-Reply-To: <JIRA.12829855.1431611163000@Atlassian.JIRA>
References: <JIRA.12829855.1431611163000@Atlassian.JIRA>
 <JIRA.12829855.1431611163654@arcas>
Subject: [jira] [Commented] (HADOOP-11969) ThreadLocal initialization in
 several classes is not thread safe
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544226#comment-14544226 ] 

Hadoop QA commented on HADOOP-11969:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 46s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 3 new or modified test files. |
| {color:red}-1{color} | javac |   6m 38s | The patch appears to cause the build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12732925/HADOOP-11969.2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 15ccd96 |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6691/console |


This message was automatically generated.

> ThreadLocal initialization in several classes is not thread safe
> ----------------------------------------------------------------
>
>                 Key: HADOOP-11969
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11969
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>              Labels: thread-safety
>         Attachments: HADOOP-11969.1.patch, HADOOP-11969.2.patch
>
>
> Right now, the initialization of hte thread local factories for encoder / decoder in Text are not marked final. This means they end up with a static initializer that is not guaranteed to be finished running before the members are visible. 
> Under heavy contention, this means during initialization some users will get an NPE:
> {code}
> (2015-05-05 08:58:03.974 : solr_server_log.log) 
>  org.apache.solr.common.SolrException; null:java.lang.NullPointerException
> 	at org.apache.hadoop.io.Text.decode(Text.java:406)
> 	at org.apache.hadoop.io.Text.decode(Text.java:389)
> 	at org.apache.hadoop.io.Text.toString(Text.java:280)
> 	at org.apache.hadoop.hdfs.protocolPB.PBHelper.convert(PBHelper.java:764)
> 	at org.apache.hadoop.hdfs.protocol.datatransfer.DataTransferProtoUtil.buildBaseHeader(DataTransferProtoUtil.java:81)
> 	at org.apache.hadoop.hdfs.protocol.datatransfer.DataTransferProtoUtil.buildClientHeader(DataTransferProtoUtil.java:71)
> 	at org.apache.hadoop.hdfs.protocol.datatransfer.Sender.readBlock(Sender.java:101)
> 	at org.apache.hadoop.hdfs.RemoteBlockReader2.newBlockReader(RemoteBlockReader2.java:400)
> 	at org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReader(BlockReaderFactory.java:785)
> 	at org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReaderFromTcp(BlockReaderFactory.java:663)
> 	at org.apache.hadoop.hdfs.BlockReaderFactory.build(BlockReaderFactory.java:327)
> 	at org.apache.hadoop.hdfs.DFSInputStream.actualGetFromOneDataNode(DFSInputStream.java:1027)
> 	at org.apache.hadoop.hdfs.DFSInputStream.fetchBlockByteRange(DFSInputStream.java:974)
> 	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:1305)
> 	at org.apache.hadoop.fs.FSInputStream.readFully(FSInputStream.java:78)
> 	at org.apache.hadoop.fs.FSDataInputStream.readFully(FSDataInputStream.java:107)
> ... SNIP...
> {code} 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)