Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A795A1760D for ; Sat, 9 May 2015 12:02:25 +0000 (UTC) Received: (qmail 47747 invoked by uid 500); 9 May 2015 12:02:25 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 47705 invoked by uid 500); 9 May 2015 12:02:25 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 47693 invoked by uid 99); 9 May 2015 12:02:25 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 May 2015 12:02:25 +0000 Date: Sat, 9 May 2015 12:02:25 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11906) test-patch.sh should use 'file' command for patch determinism MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536455#comment-14536455 ] Hudson commented on HADOOP-11906: --------------------------------- SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/922/]) HADOOP-11906. test-patch.sh should use file command for patch determinism (Sean Busbey via aw) (aw: rev effcc5cbb717fe31eb8d64e505f57bc2786399ff) * hadoop-common-project/hadoop-common/CHANGES.txt * dev-support/test-patch.sh > test-patch.sh should use 'file' command for patch determinism > ------------------------------------------------------------- > > Key: HADOOP-11906 > URL: https://issues.apache.org/jira/browse/HADOOP-11906 > Project: Hadoop Common > Issue Type: Test > Reporter: Allen Wittenauer > Assignee: Sean Busbey > Fix For: 2.8.0 > > Attachments: HADOOP-11906.1.patch, HADOOP-11906.2.patch > > > test-patch.sh currently restricts patches to the extension .patch. It might be useful to also check if the file command says it is a diff. This would allow us to determine if files that end in .txt are actually patches. -- This message was sent by Atlassian JIRA (v6.3.4#6332)