Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FFBC17A35 for ; Wed, 6 May 2015 03:39:32 +0000 (UTC) Received: (qmail 55072 invoked by uid 500); 6 May 2015 03:39:31 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 55030 invoked by uid 500); 6 May 2015 03:39:31 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 54764 invoked by uid 99); 6 May 2015 03:39:31 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2015 03:39:31 +0000 Date: Wed, 6 May 2015 03:39:31 +0000 (UTC) From: "Allen Wittenauer (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-11404) Clarify the "expected client Kerberos principal is null" authorization message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-11404: -------------------------------------- Labels: BB2015-05-TBR supportability (was: supportability) > Clarify the "expected client Kerberos principal is null" authorization message > ------------------------------------------------------------------------------ > > Key: HADOOP-11404 > URL: https://issues.apache.org/jira/browse/HADOOP-11404 > Project: Hadoop Common > Issue Type: Improvement > Components: security > Affects Versions: 2.2.0 > Reporter: Stephen Chu > Assignee: Stephen Chu > Priority: Minor > Labels: BB2015-05-TBR, supportability > Attachments: HADOOP-11404.001.patch > > > In {{ServiceAuthorizationManager#authorize}}, we throw an {{AuthorizationException}} with message "expected client Kerberos principal is null" when authorization fails. > However, this is a confusing log message, because it leads users to believe there was a Kerberos authentication problem, when in fact the the user could have authenticated successfully. > {code} > if((clientPrincipal != null && !clientPrincipal.equals(user.getUserName())) || > acls.length != 2 || !acls[0].isUserAllowed(user) || acls[1].isUserAllowed(user)) { > AUDITLOG.warn(AUTHZ_FAILED_FOR + user + " for protocol=" + protocol > + ", expected client Kerberos principal is " + clientPrincipal); > throw new AuthorizationException("User " + user + > " is not authorized for protocol " + protocol + > ", expected client Kerberos principal is " + clientPrincipal); > } > AUDITLOG.info(AUTHZ_SUCCESSFUL_FOR + user + " for protocol="+protocol); > {code} > In the above code, if clientPrincipal is null, then the user is authenticated successfully but denied by a configured ACL, not a Kerberos issue. We should improve this log message to state this. > Thanks to [~tlipcon] for finding this and proposing a fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)