Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 8 May 2015 19:24:01 +0000 (UTC)
From: "Kiran Kumar M R (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12697073.1393306952000.55331.1431113041333@Atlassian.JIRA>
In-Reply-To: <JIRA.12697073.1393306952000@Atlassian.JIRA>
References: <JIRA.12697073.1393306952000@Atlassian.JIRA>
 <JIRA.12697073.1393306952929@arcas>
Subject: [jira] [Updated] (HADOOP-10365) BufferedOutputStream in
 FileUtil#unpackEntries() should be closed in finally block
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Kumar M R updated HADOOP-10365:
-------------------------------------
    Attachment: HADOOP-10365.5.patch

Taking this issue as part of Bug Bash. [~yunsh] if you are still interested in working on this feel free to assign to yourself.
I have attached a patch using try-with-resources. [~ozawa] review the patch.

> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10365
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Ted Yu
>            Assignee: Kiran Kumar M R
>            Priority: Minor
>              Labels: BB2015-05-RFC
>         Attachments: HADOOP-10365.2.patch, HADOOP-10365.3.patch, HADOOP-10365.4.patch, HADOOP-10365.5.patch, HADOOP-10365.patch
>
>
> {code}
>     BufferedOutputStream outputStream = new BufferedOutputStream(
>         new FileOutputStream(outputFile));
> ...
>     outputStream.flush();
>     outputStream.close();
> {code}
> outputStream should be closed in finally block.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)