Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 060AA185C6 for ; Sat, 2 May 2015 04:51:19 +0000 (UTC) Received: (qmail 99736 invoked by uid 500); 2 May 2015 04:51:18 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 99688 invoked by uid 500); 2 May 2015 04:51:18 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 99616 invoked by uid 99); 2 May 2015 04:51:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 May 2015 04:51:18 +0000 Date: Sat, 2 May 2015 04:51:18 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10363) Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524899#comment-14524899 ] Hadoop QA commented on HADOOP-10363: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | patch | 0m 0s | The patch command could not apply the patch during dryrun. | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12662725/HADOOP-10363.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / f1a152c | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6354/console | This message was automatically generated. > Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null > ---------------------------------------------------------------------------------------- > > Key: HADOOP-10363 > URL: https://issues.apache.org/jira/browse/HADOOP-10363 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > Attachments: HADOOP-10363.patch > > > Here is related code: > {code} > try { > for(in = new SequenceFile.Reader(fs, srcs, job); in.next(key, value); ) { > ... > finally { > in.close(); > } > {code} > {code} > SequenceFile.Writer opWriter = null; > try { > opWriter = SequenceFile.createWriter(fs, jobconf, opList, Text.class, > FileOperation.class, SequenceFile.CompressionType.NONE); > ... > } finally { > opWriter.close(); > } > {code} > If ctor of Reader / Writer throws exception, the close() would be called on null object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)