Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 040A5183F9 for ; Sat, 2 May 2015 04:22:10 +0000 (UTC) Received: (qmail 20978 invoked by uid 500); 2 May 2015 04:22:09 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 20776 invoked by uid 500); 2 May 2015 04:22:09 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 20692 invoked by uid 99); 2 May 2015 04:22:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 May 2015 04:22:09 +0000 Date: Sat, 2 May 2015 04:22:09 +0000 (UTC) From: "Hadoop QA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-8765) LocalDirAllocator.ifExists API is broken and unused MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524562#comment-14524562 ] Hadoop QA commented on HADOOP-8765: ----------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | patch | 0m 0s | The patch command could not apply the patch during dryrun. | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12544036/HADOOP-8765-for-1-0-x.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / f1a152c | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6259/console | This message was automatically generated. > LocalDirAllocator.ifExists API is broken and unused > --------------------------------------------------- > > Key: HADOOP-8765 > URL: https://issues.apache.org/jira/browse/HADOOP-8765 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Hemanth Yamijala > Assignee: Hemanth Yamijala > Priority: Minor > Attachments: HADOOP-8765-for-1-0-x.patch, HADOOP-8765.patch > > > LocalDirAllocator.ifExists calls AllocatorPerContext.ifExists, which accesses the localDirsPath variable that is uninitialised. Hence, any code that uses this API is likely to fail with a NullPointerException. > However, this API is currently not used anywhere else in trunk. The earlier usage was in IsolationRunner, that has since been removed via MAPREDUCE-2606. > Hence, we could remove this API for trunk, and if required, fix it for the 1.x branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)