hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12038) SwiftNativeOutputStream should check whether a file exists or not before deleting
Date Fri, 29 May 2015 12:03:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564672#comment-14564672
] 

Steve Loughran commented on HADOOP-12038:
-----------------------------------------


bq. "The change is too simple "

Having spent 36 hours with a colleague tracking down a problem which turned out to be due
to a patch "too trivial for tests", I now view any patch with that assertion as a warning
sign:

http://steveloughran.blogspot.co.uk/2015/05/its-ok-to-submit-patches-without-tests.html

In the absence of a test, please give a state model describing the possible input states to
the operation, listing what concurrent changes to the filesystem make take place between the
exists() and delete() operation, then show how the patch completes successfully across all
states. Yes, this is harsh, but it'll be good practise for the bigger tests

> SwiftNativeOutputStream should check whether a file exists or not before deleting
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-12038
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12038
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Chen He
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: HADOOP-12038.000.patch
>
>
> 15/05/27 15:27:03 WARN snative.SwiftNativeOutputStream: Could not delete /tmp/hadoop-root/output-3695386887711395289.tmp
> It should check whether the file exists or not before deleting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message