hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Burlison (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12036) Consolidate all of the cmake extensions in one directory
Date Fri, 29 May 2015 23:02:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565616#comment-14565616
] 

Alan Burlison commented on HADOOP-12036:
----------------------------------------

* What about the test_bulk_crc32 app for example, is that multithreaded? If it's OK to use
-pthread on that then I think -pthread can safely be added to the global flags, as you suggest.

* I've put in a modification that allows you to preset a variable, GCC_SHARED_FLAGS. If it's
not set it currently defaults to "-g -O2 -Wall", if it is OK to do so I'll change that to
"-g -O2 -Wall -pthread -D_LARGEFILE_SOURCE", then the hadoop-yarn-project CMakeLists.txt can
simply set it appropriately before including HadoopCommon.cmake

* Sorry to sound like a stuck record but you still haven't given me what I consider to be
a satisfactory reason why _GNU_SOURCE should be set as a compiler command-line flag, even
on Linux. Just to be completely clear, I'm not intending to just remove it and have stuff
blow up on Linux, I'm intending to go through all the source and add the necessary #define/#undef
blocks so that all the Linux-specific code continues to work. Stopping this practice will
help keep the source portable, as I've explained at length in HADOOP-11997.

> Consolidate all of the cmake extensions in one directory
> --------------------------------------------------------
>
>                 Key: HADOOP-12036
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12036
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Allen Wittenauer
>            Assignee: Alan Burlison
>         Attachments: prototype01.txt
>
>
> Rather than have a half-dozen redefinitions, custom extensions, etc, we should move them
all to one location so that the cmake environment is consistent between the various native
components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message