hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Burlison (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12036) Consolidate all of the cmake extensions in one directory
Date Thu, 28 May 2015 22:24:19 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563794#comment-14563794
] 

Alan Burlison commented on HADOOP-12036:
----------------------------------------

* _REENTRANT is I believe better replaced by -pthread for gcc, as that ensures that both the
appropriate preprocessor and compiler flags are both set. However I wasn't sure that all the
native code in Hadoop was threaded so I felt it was better to explicitly specify this in each
individual CMakeList.txt file
* -D_LARGEFILE_SOURCE seems to be deprecated according to http://man7.org/linux/man-pages/man7/feature_test_macros.7.html:
"New programs should not employ this macro; defining _XOPEN_SOURCE as just described or defining
_FILE_OFFSET_BITS with the value 64 is the preferred mechanism to achieve the same result".
_FILE_OFFSET_BITS=64 is already in the current CFLAGS but I believe even that can't be made
a global option, as noted in the CMakeLists.txt for hadoop-yarn-project: "note: can't enable
-D_LARGEFILE: see MAPREDUCE-4258"
* _GNU_SOURCE isn't appropriate as a compiler command-line flag, as discussed in HADOOP-11997

> Consolidate all of the cmake extensions in one directory
> --------------------------------------------------------
>
>                 Key: HADOOP-12036
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12036
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Allen Wittenauer
>            Assignee: Alan Burlison
>         Attachments: prototype01.txt
>
>
> Rather than have a half-dozen redefinitions, custom extensions, etc, we should move them
all to one location so that the cmake environment is consistent between the various native
components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message