hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12030) test-patch should only report on newly introduced findbugs warnings.
Date Mon, 25 May 2015 18:41:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558442#comment-14558442
] 

Allen Wittenauer commented on HADOOP-12030:
-------------------------------------------

I'm not sure this is a good idea.  We've definitely seen patches that pass findbugs only to
come back in a subsequent test run blow up with errors.  Plus findbugs are one of those things
that being constantly reminded to fix is a good thing.

Also:

bq. one thing I'm not sure of is passing in FINDBUGS_HOME as a cli arg. there's no good way
to move that into a plugin.

This is why findbugs wasn't made a plugin earlier.  I always meant to go back and add some
sort of plugin hook into parse_args but never did.

> test-patch should only report on newly introduced findbugs warnings.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-12030
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12030
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>              Labels: test-patch
>         Attachments: HADOOP-12030.1.patch
>
>
> findbugs is currently reporting the total number of findbugs warnings for touched modules
rather than just newly introduced bugs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message