hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12009) FileSystemContractBaseTest:testListStatus should not assume listStatus returns sorted results
Date Wed, 27 May 2015 10:31:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560747#comment-14560747
] 

Hadoop QA commented on HADOOP-12009:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 50s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 34s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 37s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   1m  5s | The applied patch generated  1 new checkstyle
issues (total was 142, now 142). |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 4  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 40s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  23m 48s | Tests passed in hadoop-common. |
| | |  61m  9s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12735557/HADOOP-12009.1.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / bb18163 |
| checkstyle |  https://builds.apache.org/job/PreCommit-HADOOP-Build/6845/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/6845/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6845/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6845/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6845/console |


This message was automatically generated.

> FileSystemContractBaseTest:testListStatus should not assume listStatus returns sorted
results
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12009
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: J.Andreina
>            Priority: Minor
>         Attachments: HADOOP-12009.1.patch
>
>
> FileSystem.listStatus does not guarantee that implementations will return sorted entries:
> {code}  /**
>    * List the statuses of the files/directories in the given path if the path is
>    * a directory.
>    * 
>    * @param f given path
>    * @return the statuses of the files/directories in the given patch
>    * @throws FileNotFoundException when the path does not exist;
>    *         IOException see specific implementation
>    */
>   public abstract FileStatus[] listStatus(Path f) throws FileNotFoundException, 
>                                                          IOException;{code}
> However, FileSystemContractBaseTest, expects the elements to come back sorted:
> {code}    Path[] testDirs = { path("/test/hadoop/a"),
>                         path("/test/hadoop/b"),
>                         path("/test/hadoop/c/1"), };
>    
>     // ...
>     paths = fs.listStatus(path("/test/hadoop"));
>     assertEquals(3, paths.length);
>     assertEquals(path("/test/hadoop/a"), paths[0].getPath());
>     assertEquals(path("/test/hadoop/b"), paths[1].getPath());
>     assertEquals(path("/test/hadoop/c"), paths[2].getPath());{code}
> We should pass this test as long as all the paths are there, regardless of their ordering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message