hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12002) test-patch.sh needs to verify all of the findbugs tools exist
Date Mon, 25 May 2015 23:39:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558581#comment-14558581
] 

Kengo Seki commented on HADOOP-12002:
-------------------------------------

Thanks [~aw], I'd like to discuss about the last point.
Without -f condition, the expression returns true also if the path is a directory, not only
a real executable. On the other hand, I feel checking with -f is too strict because it is
very rare case. Should I remove this condition?

> test-patch.sh needs to verify all of the findbugs tools exist
> -------------------------------------------------------------
>
>                 Key: HADOOP-12002
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12002
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Sidharta Seethana
>            Assignee: Kengo Seki
>            Priority: Critical
>              Labels: test-patch
>         Attachments: HADOOP-12002.001.patch, HADOOP-12002.002.patch
>
>
> {{test-patch.sh}} was used with {{FINDBUGS_HOME}} set. See below for an example - there
were 4 findbugs warnings generated - however, {{test-patch.sh}} doesn't seem to realize that
there are missing findbugs tools and +1s the finbugs check. 
> {quote}
>  Running findbugs in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
> mvn clean test findbugs:findbugs -DskipTests -DhadoopPatchProcess > /private/tmp/hadoop-test-patch/71089/patchFindBugsOutputhadoop-yarn-server-nodemanager.txt
2>&1
> <snip>hadoop/dev-support/test-patch.sh: line 1907: /usr/local/Cellar/findbugs/3.0.0/bin/setBugDatabaseInfo:
No such file or directory
> <snip>hadoop/dev-support/test-patch.sh: line 1915: /usr/local/Cellar/findbugs/3.0.0/bin/filterBugs:
No such file or directory
> Found  Findbugs warnings (<snip>hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/findbugsXml.xml)
> <snip>hadoop/dev-support/test-patch.sh: line 1921: /usr/local/Cellar/findbugs/3.0.0/bin/convertXmlToText:
No such file or directory
> [Mon May 18 18:08:52 PDT 2015 DEBUG]: Stop clock
> Elapsed time:   0m 38s
> {quote}
> Findbugs check reported as successful : 
> {quote}
> |  +1  |           findbugs  |  0m 38s    | The patch does not introduce any 
> |      |                     |            | new Findbugs (version 3.0.0)
> |      |                     |            | warnings.
> |      |                     |  23m 51s   | 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message