hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11991) test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified
Date Mon, 18 May 2015 06:20:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547590#comment-14547590
] 

Kengo Seki commented on HADOOP-11991:
-------------------------------------

[~ajisakaa] thank you for the comment. The current script is re-exec'ed if any files under
test-patch.d are changed, because pattern "dev-support/test-patch" matches dev-support/test-patch.d/*.
I think the description of this function is inaccurate. It says "If this patches actually
patches test-patch.sh, then ...", but not only test-patch.sh, test-patch.d and smart-apply-patch.sh
are also included. So I'll fix it.

> test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-11991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11991
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>         Attachments: HADOOP-11991.001.patch
>
>
> I think this condition is wrong.
> {code}
>   if [[ ! ${CHANGED_FILES} =~ dev-support/test-patch
>       || ${CHANGED_FILES} =~ dev-support/smart-apply ]] ; then
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message