hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11978) test-patch should allow pom-only changes without test change complaints
Date Sun, 17 May 2015 20:26:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547327#comment-14547327
] 

Allen Wittenauer commented on HADOOP-11978:
-------------------------------------------

I don't think this is really the right way to solve this.

What should probably happen is the 'unit' test type should probably be broken up since it
is used for both running the unit tests and determining if tests are actually needed.  So
I'd instead, I think we should be modifying determine_needed_tests to generate a new test
type ('needstests' or something) that kick in with pom.xml, java, c, etc.

If shell code ever gets unit tests and a test framework, this will make it easier to add that
capability later.

> test-patch should allow pom-only changes without test change complaints
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-11978
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11978
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Kengo Seki
>            Priority: Minor
>         Attachments: HADOOP-11978.001.patch, HADOOP-11978.002.patch
>
>
> When a change only touches poms, we still need javac tests but we don't need to complain
that there aren't more tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message