hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11970) Replace uses of ThreadLocal<Random> with ThreadLocalRandom on branches that are JDK7+
Date Fri, 15 May 2015 07:28:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545081#comment-14545081
] 

Sean Busbey commented on HADOOP-11970:
--------------------------------------

remaining checkstyle warnings are 

{quote}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java:1: File
length is 3,251 lines (max allowed is 2,000).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:1:
File length is 3,842 lines (max allowed is 2,000).
{quote}

refactoring DFSClient and BlockManager to be ~half the size is (hopefully) out of scope?

> Replace uses of ThreadLocal<Random> with ThreadLocalRandom on branches that are
JDK7+
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11970
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11970
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-11970.1.patch, HADOOP-11970.2.patch, HADOOP-11970.3.patch
>
>
> ThreadLocalRandom should be used when available in place of ThreadLocal<Random>.
For JDK7 the difference is minimal, but JDK8 starts including optimizations for ThreadLocalRandom.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message