hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11937) Guarantee a full build of all native code during pre-commit.
Date Mon, 11 May 2015 17:30:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538223#comment-14538223
] 

Allen Wittenauer edited comment on HADOOP-11937 at 5/11/15 5:29 PM:
--------------------------------------------------------------------

bq. I don't see much opportunity for safely optimizing pre-commit run times by skipping the
native build. The Java layers 

... and if the patch doesn't touch java or the c code?  ;)


bq. Considering all of that, I'd summarize the requirements as follows. 


This kind of complex logic is *exactly* what HADOOP-11929 is designed to handle.


was (Author: aw):
bq. I don't see much opportunity for safely optimizing pre-commit run times by skipping the
native build. The Java layers 

... and if the patch doesn't touch java or the c code?  ;)

> Guarantee a full build of all native code during pre-commit.
> ------------------------------------------------------------
>
>                 Key: HADOOP-11937
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11937
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: scripts
>            Reporter: Chris Nauroth
>             Fix For: 2.8.0
>
>
> Some of the native components of the build are considered optional and either will not
build at all without passing special flags to Maven or will allow a build to proceed if dependencies
are missing from the build machine.  If these components do not get built, then pre-commit
isn't really providing full coverage of the build.  This issue proposes to update test-patch.sh
so that it does a full build of all native components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message