hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Liptak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11923) test-patch whitespace checker doesn't flag new files
Date Tue, 05 May 2015 21:55:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529358#comment-14529358
] 

Gabor Liptak commented on HADOOP-11923:
---------------------------------------

This might be a more widespread issue than whitespace. Newly added files do not trigger:

find_changed_modules
determine_needed_tests
check_reexec
check_author
check_modified_unittests

Maybe somebody can comment why new files were being filtered?

Thanks

> test-patch whitespace checker doesn't flag new files
> ----------------------------------------------------
>
>                 Key: HADOOP-11923
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11923
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sean Busbey
>            Priority: Critical
>         Attachments: HADOOP-11923.patch
>
>
> The whitespace plugin for test-patch only examines new files. So when a patch comes in
with trailing whitespace on new files it doesn't flag things as a problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message