hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11923) test-patch whitespace checker doesn't flag new files
Date Wed, 06 May 2015 09:37:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530244#comment-14530244
] 

Steve Loughran commented on HADOOP-11923:
-----------------------------------------

I don't see why we should care about whitespace in patch; we can just lay down that whoever
commits the patch needs to merge it in with

{code}
git apply --whitespace=fix  
{code}

& let git sort things out. 

> test-patch whitespace checker doesn't flag new files
> ----------------------------------------------------
>
>                 Key: HADOOP-11923
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11923
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sean Busbey
>            Priority: Critical
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-11923.patch
>
>
> The whitespace plugin for test-patch only examines new files. So when a patch comes in
with trailing whitespace on new files it doesn't flag things as a problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message