hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11911) test-patch should allow configuration of default branch
Date Mon, 04 May 2015 05:58:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526290#comment-14526290
] 

Allen Wittenauer edited comment on HADOOP-11911 at 5/4/15 5:57 AM:
-------------------------------------------------------------------

bq. that would be better because as is if the repo ends up not on branch then git pull --rebase
will fail because it won't know what to rebase.

BTW, that doesn't happen with the --force checkout to trunk....

So really, if you remove all of those changes and leave just the ones that set and work with
PATCH_BRANCH_DEFAULT, this could get committed...


was (Author: aw):
bq. that would be better because as is if the repo ends up not on branch then git pull --rebase
will fail because it won't know what to rebase.

BTW, that doesn't happen with the --force checkout to trunk....

So really, if you remove all of those changes and just the ones that set PATCH_BRANCH_DEFAULT,
this could get committed...

> test-patch should allow configuration of default branch
> -------------------------------------------------------
>
>                 Key: HADOOP-11911
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11911
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: HADOOP-11911.1.patch, HADOOP-11911.2.patch
>
>
> right now test-patch.sh forces a default branch of 'trunk'. would be better to allow
it to be configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message