hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11910) add command line arg to test-patch for the regex to use for evaluating if something is a patch file.
Date Wed, 06 May 2015 01:57:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529753#comment-14529753
] 

Allen Wittenauer commented on HADOOP-11910:
-------------------------------------------

bq, Given that we need a review for patches anyway, the reviewer can just tell the new contributor
how to name their patch, right?

The first thing that will happen will be the reviewer saying "Rename your file so that the
automated system will kick in."  So why not remove this friction point and just let the automated
system do it for us?  

> add command line arg to test-patch for the regex to use for evaluating if something is
a patch file.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-11910.1.patch
>
>
> right now before test-patch can be used on a submission it checks if the file ends with
".patch". we should make this configurable so that it can be used with other projects that
might want to be more permissive (i.e. ".patch.txt")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message