hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11906) test-patch.sh should use 'file' command for patch determinism
Date Wed, 06 May 2015 15:11:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530682#comment-14530682
] 

Sean Busbey commented on HADOOP-11906:
--------------------------------------

For comparison, if I use the heuristic "does the first line look like a patch?" I get 417
out of 428:

{code}
$ find ../patches/ -type f -exec head -n 1 {} \; | grep -E "^(From [a-z0-9]* Mon Sep 17 00:00:00
2001)|(diff .*)|(Index: .*)$" | wc -l
     417
$ find ../patches/ -type f -exec head -n 1 {} \; | grep -v -E "^(From [a-z0-9]* Mon Sep 17
00:00:00 2001)|(diff .*)|(Index: .*)$" | wc -l
      11
{code}

> test-patch.sh should use 'file' command for patch determinism
> -------------------------------------------------------------
>
>                 Key: HADOOP-11906
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11906
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Allen Wittenauer
>            Assignee: Sean Busbey
>
> test-patch.sh currently restricts patches to the extension .patch.  It might be useful
to also check if the file command says it is a diff.  This would allow us to determine if
files that end in .txt are actually patches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message