hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11887) Introduce Intel ISA-L erasure coding library for the native support
Date Tue, 05 May 2015 19:00:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529061#comment-14529061
] 

Colin Patrick McCabe commented on HADOOP-11887:
-----------------------------------------------

{code}
25	#cmakedefine HADOOP_ERASURECODE_LIBRARY "libisal.so"
{code}
This should be set based on the name we found in the {{CMakeLists.txt}}.

{code}
76	static void *libec = NULL;
77	char errMsg[1000];
78	
79	char* load_erasure_code_lib() {
{code}

Why are these variables global?  Why is {{load_erasure_code_lib}} returning a value that no
functions are checking?

In general, we shouldn't have every function calling {{load_erasure_code_lib}}.  Instead,
a static block in the java file should call {{load_erasure_code_lib}} once on startup.  If
the function fails, it needs to raise a JNI exception.

I would really prefer not to change {{org_apache_hadoop.h}} here just for the sake of a unit
test.  Let's just not call these functions if we aren't using JNI.

{code}
44	    <bundle.erasurecode>false</bundle.erasurecode>
{code}
Should this default to true?  I don't think any Linux distros provide this library, so it's
important to bundle it.

> Introduce Intel ISA-L erasure coding library for the native support
> -------------------------------------------------------------------
>
>                 Key: HADOOP-11887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11887
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11887-v1.patch
>
>
> This is to introduce Intel ISA-L erasure coding library for the native support, via dynamic
loading mechanism (dynamic module, like *.so in *nix and *.dll on Windows).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message