hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11887) Introduce Intel ISA-L erasure coding library for the native support
Date Thu, 28 May 2015 08:02:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562456#comment-14562456
] 

Kai Zheng commented on HADOOP-11887:
------------------------------------

I'm not feeling perfect in the update because in the following change it used the deprecated
{{task}} instead of {{target}}. I have no better idea to make it work. Colin how do you like
this? Thanks.
{code}
                 <configuration>
-                  <target>
-                    <exec executable="sh" failonerror="true" dir="${project.build.directory}/native">
-                      <arg value="-c"/>
-                      <arg value="[ x$SKIPTESTS = xtrue ] || ${project.build.directory}/native/test_bulk_crc32"/>
-                      <env key="SKIPTESTS" value="${skipTests}"/>
+                  <skip>${skipTests}</skip>
+                  <tasks>
+                    <taskdef resource="net/sf/antcontrib/antcontrib.properties"
+                             classpathref="maven.plugin.classpath" />
+                    <property name="native_dir" value="${project.build.directory}/native"/>
+                    <exec executable="${native_dir}/test_bulk_crc32" failonerror="true"
dir="${native_dir}"/>
+                    <exec executable="${native_dir}/check_native_lib" resultproperty="erasureCodeLibAvailable"
dir="${native_dir}">
+                      <arg value="HADOOP_ERASURECODE_LIBRARY"/>
                     </exec>
-                  </target>
+                    <if>
+                      <equals arg1="${erasureCodeLibAvailable}" arg2="0"/>
+                      <then>
+                        <exec executable="${native_dir}/erasure_code_test" failonerror="true"
dir="${native_dir}"/>
+                      </then>
+                      <else>
+                        <echo message="Erasure code native library isn't available, test
skipped: ${erasureCodeLibAvailable}" />
+                      </else>
+                    </if>
+                  </tasks>
                 </configuration>
               </execution>
             </executions>
+            <dependencies>
+              <dependency>
+                <groupId>ant-contrib</groupId>
+                <artifactId>ant-contrib</artifactId>
+                <version>20020829</version>
+              </dependency>
+            </dependencies>
{code}

> Introduce Intel ISA-L erasure coding library for the native support
> -------------------------------------------------------------------
>
>                 Key: HADOOP-11887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11887
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11887-v1.patch, HADOOP-11887-v2.patch, HADOOP-11887-v3.patch,
HADOOP-11887-v4.patch
>
>
> This is to introduce Intel ISA-L erasure coding library for the native support, via dynamic
loading mechanism (dynamic module, like *.so in *nix and *.dll on Windows).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message