hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11869) checkstyle rules/script need re-visiting
Date Mon, 04 May 2015 20:04:07 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Eagles updated HADOOP-11869:
-------------------------------------
    Attachment: HADOOP-11869.ParameterNumber.patch

A specific ask is to relax parameter number to ignore methods with \@Override annotation.
Attaching a sample patch for that change.

> checkstyle rules/script need re-visiting
> ----------------------------------------
>
>                 Key: HADOOP-11869
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11869
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sidharta Seethana
>         Attachments: HADOOP-11869.ParameterNumber.patch
>
>
> There seem to be a lot of arcane errors being caused by the checkstyle rules/script.
Real issues tend to be buried in this noise. Some examples :
> 1. "Line is longer than 80 characters" - this shows up even for cases like import statements,
package names
> 2. "Missing a Javadoc comment." - for every private member including cases like "Configuration
conf". 
> Having rules like these will result in a large number of pre-commit job failures. We
should fine tune the rules used for checkstyle. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message