hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11089) change "-tokenCacheFile" option to support non-local FS URIs.
Date Sun, 03 May 2015 03:30:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525625#comment-14525625
] 

Hadoop QA commented on HADOOP-11089:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 35s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 32s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 32s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  5s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 39s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  22m 53s | Tests passed in hadoop-common. |
| | |  59m 46s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12668523/HADOOP-11089.000.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e8d0ee5 |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6444/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6444/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6444/console |


This message was automatically generated.

> change "-tokenCacheFile" option to support non-local FS URIs.
> -------------------------------------------------------------
>
>                 Key: HADOOP-11089
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11089
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security, util
>    Affects Versions: 2.5.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: HADOOP-11089.000.patch
>
>
> change "-tokenCacheFile" option to support non-local FS URIs.
> The current code in GenericOptionsParser only support local FS URIs, It will be better
to support non-local FS URIs. 
> {code}
>     FileSystem localFs = FileSystem.getLocal(conf);
>       Path p = localFs.makeQualified(new Path(fileName));
>       if (!localFs.exists(p)) {
>           throw new FileNotFoundException("File "+fileName+" does not exist.");
>       }
> {code}
> We can change above code to
> {code}
>     FileSystem localFs = FileSystem.getLocal(conf);
>       Path p = localFs.makeQualified(new Path(fileName));
>       if (!p.getFileSystem(conf).exists(p)) {
>           throw new FileNotFoundException("File "+fileName+" does not exist.");
>       }
> {code}
> This issue will depend on MAPREDUCE-6086.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message