hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10661) Ineffective user/passsword check in FTPFileSystem#initialize()
Date Sat, 02 May 2015 04:51:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524892#comment-14524892
] 

Hadoop QA commented on HADOOP-10661:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during
dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12654632/HADOOP-10661.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6352/console |


This message was automatically generated.

> Ineffective user/passsword check in FTPFileSystem#initialize()
> --------------------------------------------------------------
>
>                 Key: HADOOP-10661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10661
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: HADOOP-10661.patch, HADOOP-10661.patch
>
>
> Here is related code:
> {code}
>       userAndPassword = (conf.get("fs.ftp.user." + host, null) + ":" + conf
>           .get("fs.ftp.password." + host, null));
>       if (userAndPassword == null) {
>         throw new IOException("Invalid user/passsword specified");
>       }
> {code}
> The intention seems to be checking that username / password should not be null.
> But due to the presence of colon, the above check is not effective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message