hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10366) [Doc] wrap value of io.serializations in core-default.xml to fit better in browser
Date Sun, 17 May 2015 01:43:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547011#comment-14547011
] 

Akira AJISAKA commented on HADOOP-10366:
----------------------------------------

Hi [~kanaka], thank you for taking this issue.
I don't think it's a good idea to render the value in the fixed number of characters. Users
may copy and paste the parameter, which is rendered in the middle of the classes, from browser.
As the result, application can fail.
I'm thinking it makes more sense to add a whitespace between the classes as follows:
{code}
<value>org.apache.hadoop.io.serializer.WritableSerialization, org.apache.hadoop.io.serializer.avro.AvroSpecificSerialization,
org.apache.hadoop.io.serializer.avro.AvroReflectSerialization</value>
{code}
That way we can fix the problem. When the value is read from o.a.h.io.serializer.SerializationFactory,
the whitespaces are trimmed.

> [Doc] wrap value of io.serializations in core-default.xml to fit better in browser
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10366
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10366
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 3.0.0
>            Reporter: Chengwei Yang
>            Assignee: kanaka kumar avvaru
>            Priority: Trivial
>              Labels: BB2015-05-RFC, documentation, newbie, patch
>         Attachments: HADOOP-10366-wrap01, HADOOP-10366-wrap01.patch, HADOOP-10366-wrap02.patch,
HADOOP-10366.patch
>
>
> The io.serialization property in core-default.xml has a very long value in a single line,
as below
> {code}
> <property>
>   <name>io.serializations</name>
>   <value>org.apache.hadoop.io.serializer.WritableSerialization,org.apache.hadoop.io.serializer.avro.AvroSpecificSerialization,org.apache.hadoop.io.serializer.avro.AvroReflectSerialization</value>
>   <description>A list of serialization classes that can be used for
>   obtaining serializers and deserializers.</description>
> </property>
> {code}
> which not only break the code style (a very long line) but also not fit well in browser.
Due to this single very long line, the "description" column can not show in browser by default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message