hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10363) Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null
Date Sat, 02 May 2015 04:51:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524899#comment-14524899
] 

Hadoop QA commented on HADOOP-10363:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during
dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12662725/HADOOP-10363.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6354/console |


This message was automatically generated.

> Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10363
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10363.patch
>
>
> Here is related code:
> {code}
>       try {
>         for(in = new SequenceFile.Reader(fs, srcs, job); in.next(key, value); ) {
> ...
>       finally {
>         in.close();
>       }
> {code}
> {code}
>     SequenceFile.Writer opWriter = null;
>     try {
>       opWriter = SequenceFile.createWriter(fs, jobconf, opList, Text.class,
>           FileOperation.class, SequenceFile.CompressionType.NONE);
> ...
>     } finally {
>       opWriter.close();
>     }
> {code}
> If ctor of Reader / Writer throws exception, the close() would be called on null object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message