hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10356) Corrections in winutils/chmod.c
Date Sat, 02 May 2015 21:28:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525497#comment-14525497
] 

Hadoop QA commented on HADOOP-10356:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   5m 17s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 46s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | common tests |  23m 33s | Tests passed in hadoop-common. |
| | |  39m  2s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12630265/HADOOP-10356.patch
|
| Optional Tests | javac unit |
| git revision | trunk / 6ae2a0d |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6424/console |


This message was automatically generated.

> Corrections in winutils/chmod.c
> -------------------------------
>
>                 Key: HADOOP-10356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10356
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: bin
>         Environment: Windows
>            Reporter: René Nyffenegger
>            Priority: Trivial
>         Attachments: HADOOP-10356.patch
>
>
> There are two small things in winutils/chmod.c:
>   pathName should be pointer to a constant WSTR
>   the declartion
>       LPWSTR pathName = NULL;
>   seems to be wrong.
>         LPCWSTR pathName = NULL;
>    should b used instead.
>   ------------------------------------------------
>    I believe the fragment
>       switch (c)
>       {
>       case NULL:
>    to be wrong as pointers are not permitted as
>    case values.
>   ------------------------------------------------



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message