hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kiran Kumar M R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10356) Corrections in winutils/chmod.c
Date Wed, 06 May 2015 14:35:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530637#comment-14530637
] 

Kiran Kumar M R commented on HADOOP-10356:
------------------------------------------

Reviewed and verified patch.
{{case NULL:}} is not correct.  It is {{void *}} pointer. 
VC++ compiler is allowing this somehow. This is usually not allowed in gcc. 
So changing this to {{NULL Termination '\0'}}  is correct fix.

Existing patch applies on both trunk and branch-2. No new patch needed.
Compiled and tested this patch on windows. Its working fine.
No new compilation warnings found.

This can be committed.


> Corrections in winutils/chmod.c
> -------------------------------
>
>                 Key: HADOOP-10356
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10356
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: bin
>         Environment: Windows
>            Reporter: René Nyffenegger
>            Assignee: Kiran Kumar M R
>            Priority: Trivial
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-10356.patch
>
>
> There are two small things in winutils/chmod.c:
>   pathName should be pointer to a constant WSTR
>   the declartion
>       LPWSTR pathName = NULL;
>   seems to be wrong.
>         LPCWSTR pathName = NULL;
>    should b used instead.
>   ------------------------------------------------
>    I believe the fragment
>       switch (c)
>       {
>       case NULL:
>    to be wrong as pointers are not permitted as
>    case values.
>   ------------------------------------------------



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message