hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9723) Improve error message when hadoop archive output path already exists
Date Fri, 08 May 2015 17:36:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535041#comment-14535041

Yongjun Zhang commented on HADOOP-9723:

HI [~ajisakaa],

Thanks for your earlier patch, it looks good to me, except a few very minor thing.

* Change "Destination directory xyz is a file" message to "Destination xyz should be a directory
but is a file"; and change the test method accordingly
* Use upper case in one exception "Source path ..." instead of "source path ..."
* Change testExistingOutput to testOutputPathValidity,

 I'm in bug bash right now, to avoid another iteration, I'm uploading a revised version to
address the above comments, hope you don't mind. Please comment on the change if you agree
with the change.I will commit after you agree and jenkins test.


> Improve error message when hadoop archive output path already exists
> --------------------------------------------------------------------
>                 Key: HADOOP-9723
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9723
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 2.0.4-alpha
>            Reporter: Stephen Chu
>            Assignee: Akira AJISAKA
>            Priority: Trivial
>              Labels: supportability
>         Attachments: HADOOP-9723.2.patch, HADOOP-9723.patch
> When creating a hadoop archive and specifying an output path of an already existing file,
we get an "Invalid Output" error message.
> {code}
> [schu@hdfs-vanilla-1 ~]$ hadoop archive -archiveName foo.har -p /user/schu testDir1 /user/schu
> Invalid Output: /user/schu/foo.har
> {code}
> This error can be improved to tell users immediately that the output path already exists.

This message was sent by Atlassian JIRA

View raw message