hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9658) SnappyCodec#checkNativeCodeLoaded may unexpectedly fail when native code is not loaded
Date Sat, 02 May 2015 20:16:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525455#comment-14525455
] 

Hadoop QA commented on HADOOP-9658:
-----------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 38s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 28s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 40s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  5s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 40s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  23m 35s | Tests passed in hadoop-common. |
| | |  60m 39s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12589159/HADOOP-9658.1.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6416/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6416/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6416/console |


This message was automatically generated.

> SnappyCodec#checkNativeCodeLoaded may unexpectedly fail when native code is not loaded
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9658
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9658
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: HADOOP-9658.1.patch
>
>
> {code}
>   public static void checkNativeCodeLoaded() {
>       if (!NativeCodeLoader.buildSupportsSnappy()) {
>         throw new RuntimeException("native snappy library not available: " +
>             "this version of libhadoop was built without " +
>             "snappy support.");
>       }
>       if (!SnappyCompressor.isNativeCodeLoaded()) {
>         throw new RuntimeException("native snappy library not available: " +
>             "SnappyCompressor has not been loaded.");
>       }
>       if (!SnappyDecompressor.isNativeCodeLoaded()) {
>         throw new RuntimeException("native snappy library not available: " +
>             "SnappyDecompressor has not been loaded.");
>       }
>   }
> {code}
> buildSupportsSnappy is native method. If the native code is not loaded, the method will
be missing. Therefore, whether the native code is loaded or not, the first runtime exception
will not be thrown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message