Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A822517F9B for ; Fri, 24 Apr 2015 02:15:39 +0000 (UTC) Received: (qmail 61389 invoked by uid 500); 24 Apr 2015 02:15:39 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 61333 invoked by uid 500); 24 Apr 2015 02:15:39 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 61321 invoked by uid 99); 24 Apr 2015 02:15:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2015 02:15:39 +0000 Date: Fri, 24 Apr 2015 02:15:39 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11802) DomainSocketWatcher thread terminates sometimes after there is an I/O error during requestShortCircuitShm MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510353#comment-14510353 ] Hudson commented on HADOOP-11802: --------------------------------- SUCCESS: Integrated in Hadoop-trunk-Commit #7658 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7658/]) HADOOP-11802. DomainSocketWatcher thread terminates sometimes after there is an I/O error during requestShortCircuitShm (cmccabe) (cmccabe: rev a0e0a63209b5eb17dca5cc503be36aa52defeabd) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DomainSocketFactory.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeFaultInjector.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/unix/DomainSocketWatcher.java * hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocketWatcher.c > DomainSocketWatcher thread terminates sometimes after there is an I/O error during requestShortCircuitShm > --------------------------------------------------------------------------------------------------------- > > Key: HADOOP-11802 > URL: https://issues.apache.org/jira/browse/HADOOP-11802 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Eric Payne > Assignee: Colin Patrick McCabe > Fix For: 2.7.1 > > Attachments: HADOOP-11802.001.patch, HADOOP-11802.002.patch, HADOOP-11802.003.patch, HADOOP-11802.004.patch > > > In {{DataXceiver#requestShortCircuitShm}}, we attempt to recover from some errors by closing the {{DomainSocket}}. However, this violates the invariant that the domain socket should never be closed when it is being managed by the {{DomainSocketWatcher}}. Instead, we should call {{shutdown}} on the {{DomainSocket}}. When this bug hits, it terminates the {{DomainSocketWatcher}} thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)