Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F157E17FA4 for ; Thu, 2 Apr 2015 00:40:53 +0000 (UTC) Received: (qmail 90263 invoked by uid 500); 2 Apr 2015 00:40:53 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 90200 invoked by uid 500); 2 Apr 2015 00:40:53 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 90188 invoked by uid 99); 2 Apr 2015 00:40:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2015 00:40:53 +0000 Date: Thu, 2 Apr 2015 00:40:53 +0000 (UTC) From: "Li Lu (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-11776) jdiff is broken in Hadoop 2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Li Lu updated HADOOP-11776: --------------------------- Attachment: HADOOP-11776-040115.patch Worked on this issue on top of [~ozawa]'s HADOOP-11377 patch. That patch addressed the Null.java problem for me. In this patch I'm doing the following things: # Applied a quick fix for the jdiff compatibility param settings to eliminate the package "" error. I'd appreciate if there's background information about this setting, so that we can decide the correct long term fix. # Run the maven script against branch-2.6.0 to generate two sample API files, one for hadoop-common-project/hadoop-common and one for hadoo-hdfs-project/hadoop-hdfs # Fix the SAXParser not found exception when running jdiff. After this fix, hadoop hdfs can have API diff report after {{mvn package -Pdocs -DskipTests}} in its target/site/jdiff/xml folder. Hadoop common still has some problem with jdiff: jdiff is complainging the following: [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T) Since this is the only error we got in all components (we're also exploring YARN-3426 for yarn-api, yarn-client, yarn-common, and yarn-server-common), after briefly checking the original code of jdiff I highly suspect the error is triggered by a bug of jdiff. However, I'm not sure if jdiff is still maintained, so for long term fix we may want to find some alternative tools. So far the script would generate a diff report for hdfs. I'm extending the YARN part in YARN-3426. The patch in HADOOP-11377 appears to work on my local machine. > jdiff is broken in Hadoop 2 > --------------------------- > > Key: HADOOP-11776 > URL: https://issues.apache.org/jira/browse/HADOOP-11776 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: Li Lu > Assignee: Li Lu > Priority: Blocker > Attachments: HADOOP-11776-040115.patch > > > Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)