hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11800) Clean up some test methods in TestCodec.java
Date Fri, 03 Apr 2015 14:19:52 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394463#comment-14394463
] 

Hadoop QA commented on HADOOP-11800:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12709227/HADOOP-11800.patch
  against trunk revision 72f6bd4.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6058//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6058//console

This message is automatically generated.

> Clean up some test methods in TestCodec.java
> --------------------------------------------
>
>                 Key: HADOOP-11800
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11800
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>              Labels: newbie
>         Attachments: HADOOP-11800.patch
>
>
> Found two issues when reviewing the patches in HADOOP-11627.
> 1. There is no {{@Test}} annotation, so the test is not executed.
> {code}
>   public void testCodecPoolAndGzipDecompressor() {
> {code}
> 2. The method should be private because it is called from other tests.
> {code}
>   public void testGzipCodecWrite(boolean useNative) throws IOException {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message