hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11746) rewrite test-patch.sh
Date Mon, 20 Apr 2015 07:32:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502467#comment-14502467
] 

Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------

bq.  I found that surprising, as compared to say "-0" since in those cases the QA bot can't
judge the suitability of the patch.

This is actually how the old test-patch.sh works as well.  I tend to agree with the -1 because
if the base universe is broken, it really can't judge how well the patch is going to work
either.  The +1's are going to be false flags. 

bq. The rewrite is a great improvement. Any idea what else you want to cover before pushing?

Thanks! Not really.  Playing around with HADOOP-11843 (which upgraded shellcheck) and realizing
I hadn't exercised the site tests yet popped up the problems fixed in -19.  At this point,
I think all the subsystems have been thoroughly worked (at least by me) so any outstanding
issues will likely be edge case bugs and/or issues with the Jenkins build environment.

[There are one or two more optimizations I could make in site tests, but since those run so
quickly anyway, they aren't a big concern.]

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch,
HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch,
HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch,
HADOOP-11746-16.patch, HADOOP-11746-17.patch, HADOOP-11746-18.patch, HADOOP-11746-19.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message