hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
Date Thu, 09 Apr 2015 17:51:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487749#comment-14487749
] 

Allen Wittenauer edited comment on HADOOP-11746 at 4/9/15 5:51 PM:
-------------------------------------------------------------------

-13:
* fix an issue where a git ref may be in the future vs. the copy on disk.  We no longer do
a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the total count
was higher. Also smarter about picking up on patches that patch shell code that are not in
the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it is
* findbugs moved into its own optional test instead of being tied to javac so that pom.xml,
native code, etc, won't trigger a run. (This does mean that testing findbugs itself will get
missed now... but that's a very rare occurrence...)

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13 @author tags
which the Hadoop  community has agreed to not allow in code contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no   lines that end in whitespace.
|
| {color:green}+1{color} | release audit | 00m 08s | The applied patch does not increase the
total number of release audit warnings. |
| {color:red}-1{color} | shellcheck | 00m 03s | The applied patch generated  6 new shellcheck
issues (total was 165, now 27). |



was (Author: aw):
-13:
* fix an issue where a git ref may be in the future vs. the copy on disk.  We no longer do
a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the total count
was higher. Also smarter about picking up on patches that patch shell code that are not in
the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it is
* findbugs moved into its own optional test instead of being tied to javac so that pom.xml,
native code, etc, won't trigger a run. (This does mean that testing findbugs itself will get
missed now... but that's a very rare occurrence...)


> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch,
HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch,
HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch, HADOOP-11746-13.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message