hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
Date Sun, 19 Apr 2015 19:27:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502068#comment-14502068
] 

Allen Wittenauer edited comment on HADOOP-11746 at 4/19/15 7:27 PM:
--------------------------------------------------------------------

-19:
* Merged in the fixes from HADOOP-11845, otherwise rat checks fail because mvn site generates
a file that violates rat.  this also enables shelldocs to actually build documentation for
test-patch's API too.
* shellcheck test reports version of shellcheck
* shellcheck find command was very broken
* upgraded my local copy of shellcheck, which now includes some new checks. fixed errors from
those new checks (mainly local blah=subshell issues)
* somewhere along the way, the value of the initial cwd got screwed up.
* re-arranged the findbugs code a bit to give more realistic times
* if for some reason openssl or base64 throws an error, just send them to /dev/null
* fixed a minor message bug in the site check


was (Author: aw):
-19:
* Merged in the fixes from HADOOP-11845, otherwise rat checks fail because mvn site generates
a file that violates rat
* shellcheck test reports version of shellcheck
* shellcheck find command was very broken
* upgraded my local copy of shellcheck, which now includes some new checks. fixed errors from
those new checks (mainly local blah=subshell issues)
* somewhere along the way, the value of the initial cwd got screwed up.
* re-arranged the findbugs code a bit to give more realistic times
* if for some reason openssl or base64 throws an error, just send them to /dev/null
* fixed a minor message bug in the site check

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch,
HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch,
HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, HADOOP-11746-15.patch,
HADOOP-11746-16.patch, HADOOP-11746-17.patch, HADOOP-11746-18.patch, HADOOP-11746-19.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message