Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7D7510A2E for ; Sat, 21 Mar 2015 14:38:44 +0000 (UTC) Received: (qmail 12330 invoked by uid 500); 21 Mar 2015 14:38:44 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 12287 invoked by uid 500); 21 Mar 2015 14:38:44 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 12274 invoked by uid 99); 21 Mar 2015 14:38:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Mar 2015 14:38:44 +0000 Date: Sat, 21 Mar 2015 14:38:44 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-11709) Time.NANOSECONDS_PER_MILLISECOND - use class-level final constant instead of method variable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-11709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372798#comment-14372798 ] Hudson commented on HADOOP-11709: --------------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #130 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/130/]) HADOOP-11709. Time.NANOSECONDS_PER_MILLISECOND - use class-level final constant instead of method variable. Contributed by Ajith S. (ozawa: rev 43dde502b3be2133d62f1f074f016f35a56a7e2c) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Time.java > Time.NANOSECONDS_PER_MILLISECOND - use class-level final constant instead of method variable > --------------------------------------------------------------------------------------------- > > Key: HADOOP-11709 > URL: https://issues.apache.org/jira/browse/HADOOP-11709 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Ajith S > Assignee: Ajith S > Priority: Trivial > Labels: beginner, newbie > Fix For: 2.8.0 > > Attachments: 001-HDFS-7919.patch > > > NANOSECONDS_PER_MILLISECOND constant can be moved to class level instead of creating it in each method call. > {code} > org.apache.hadoop.util.Time.java > public static long monotonicNow() { > final long NANOSECONDS_PER_MILLISECOND = 1000000; > return System.nanoTime() / NANOSECONDS_PER_MILLISECOND; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)